komodojp / tinyld

Simple and Performant Language detection library for NodeJS
https://komodojp.github.io/tinyld/
MIT License
415 stars 12 forks source link

missing 'data' directory in package #11

Closed leonardlin closed 2 years ago

leonardlin commented 2 years ago

I'm trying to install the tinyld to work on it a bit. (see the two issues I opened)

npm run build runs into a problem with missing './data/bench/tinyld.json''

I saw in the code that it's created during bench npm run bench npm run train

both run into missing data-directory files.

Can these files be added to the repo or made available for download?

kefniark commented 2 years ago

so the process, sorry I should have documented that better in here

But it's a totally valid point, we shouldn't need to run yarn bench before yarn build. So I added that data/bench folder to the repo and make it an optional step.

👍