komodorio / helm-dashboard

The missing UI for Helm - visualize your releases
Apache License 2.0
4.99k stars 302 forks source link

Handled resource kind PodDisruptionBudget and CRD for health status. #448

Closed iamvikaskumar closed 1 year ago

iamvikaskumar commented 1 year ago

Changes Proposed

Added hdHealth status for PodDisruptionBudget and CRD. Below is the criterion for healthy status : For CRD : if both the conditions (Established and NamesAccepted) are true. For PodDisruptionBudget : if condition DisruptionAllowed is true.

Check List

codecov-commenter commented 1 year ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.87%. Comparing base (64331ad) to head (9867084). Report is 63 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #448 +/- ## ======================================= Coverage 29.87% 29.87% ======================================= Files 10 10 Lines 1339 1339 ======================================= Hits 400 400 Misses 900 900 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

undera commented 1 year ago

Looks good. gocyclo complaints can be addressed in a separate PR.