Fix resource status not enhanced for calls to /api/k8s/{kind}/get route

komodorio / helm-dashboard

The missing UI for Helm - visualize your releases

Apache License 2.0

4.99k stars 302 forks source link

Fix resource status not enhanced for calls to /api/k8s/{kind}/get route #517

Closed alessandrodetta closed 9 months ago

alessandrodetta commented 9 months ago

Changes Proposed

The pointer address returned from EnhanceStatus is now correctly set, following the same structure adopted in Resources function of /pkg/dashboard/handlers/helmHandlers.go

Check List

[x] The title of my pull request is a short description of the changes
[x] This PR relates to some issue: Closes #516
[ ] I have documented the changes made (if applicable)
[ ] I have covered the changes with unit tests

undera commented 9 months ago

After looking a bit into it, I don't see this code called at all. Did you find the use action when it's called?

alessandrodetta commented 9 months ago

@undera I just limited my search to backend while testing the REST API for understanding purposes.

Now that I look into frontend, I don't find any usage either. I don't know if it makes sense then to apply a fix to something that is still not in a final state or will be removed... I assumed that the endpoint was used because it existed. In any case, if you want to keep the call to EnhanceStatus inside the function, that piece of code will have to be fixed.

undera commented 9 months ago

Let's have it fixed anyway. Probably the endpoint should be marked as deprecated.

undera commented 9 months ago

Thank you for reporting this inconsistency!

alessandrodetta commented 9 months ago

Let's have it fixed anyway. Probably the endpoint should be marked as deprecated.

Thank you for reporting this inconsistency!

The pleasure is mine! Rather excuse me, I still have a lot to learn in order to contribute better in the project and on github in general :slightly_smiling_face: