komodorio / helm-dashboard

The missing UI for Helm - visualize your releases
Apache License 2.0
4.81k stars 286 forks source link

Add husky to the project #534

Open Ameerjafar opened 3 weeks ago

Ameerjafar commented 3 weeks ago

Description

currently in our project we don't have husky if we use husky we can easily formatting the code if before the make the commit by using pre commit

Screenshots

No response

Additional information

No response

Ameerjafar commented 3 weeks ago

@undera can you please assign me this issue i really wanted to work on this enhancement man.

undera commented 3 weeks ago

@Ameerjafar I'm not sure what this issue is about. Does the project have issues with code formatting? None that I know of. Can you give examples?

Generally, feel free to bring PR with the changes you propose, no need for formal assignments.

Ameerjafar commented 3 weeks ago

it the contributor changed something in the codebase but if he/she did not formatting the code properly if we use husky, before the commit the code automatically formatted sir. @undera

undera commented 3 weeks ago

Bring the PR, we'll see what happens. Not all the automatic formatting that is good.

Ameerjafar commented 3 weeks ago

just the changed file only formatting sir before the commit @undera

undera commented 3 weeks ago

I understand that. So where's the PR with proposed changes?

Ameerjafar commented 3 weeks ago

I understand that. So where's the PR with proposed changes?

done sir