search

komodorio / validkube

ValidKube combines the best open-source tools to help ensure Kubernetes YAML best practices, hygiene & security.
https://validkube.com
Apache License 2.0
767 stars 60 forks source link

Dark and Light Theme Toggle Functionality #40

Closed stevenovak123 closed 2 years ago

stevenovak123 commented 2 years ago

I ran the scripts in the frontend to lint and still they have shown up in the changes. Sorry for the difficulty caused.

nirsht commented 2 years ago

@stevenovak123 can you explain more in details what is the problem ?

nirsht commented 2 years ago

@stevenovak123 Can you also attach pics to here ?

stevenovak123 commented 2 years ago

@stevenovak123 can you explain more in details what is the problem ?

I use prettier as well but my config has them in ' ' instead of " ". I think it is due to the fact there is not a prettier rules file set in the project. if that config file is made and pushed then it will automatically lint it to a default set.

stevenovak123 commented 2 years ago

Added the necessary changes as requested. separated the context logic and corrected the " ". Attaching the images of how the changes look. The theme switching button is located on the Navbar beside the github icon. validkube validkubeLightMode_

nirsht commented 2 years ago

Hi @stevenovak123 looks great, just to verify, the default theme is dark ?

I am AFK for few days, after that I will merge it and deploy it 🎉

stevenovak123 commented 2 years ago

Hi @stevenovak123 looks great, just to verify, the default theme is dark ?

I am AFK for few days, after that I will merge it and deploy it 🎉

The default is set depending on the users' browser settings.