search

komodorio / validkube

ValidKube combines the best open-source tools to help ensure Kubernetes YAML best practices, hygiene & security.
https://validkube.com
Apache License 2.0
759 stars 59 forks source link

Github logo at top right not working for validkube. #64

Open 7h3-3mp7y-m4n opened 11 months ago

7h3-3mp7y-m4n commented 11 months ago

While moving the cursor toward the GitHub logo at the top right of the website, the logo should redirect to the desired repo , but is not redirecting itself to the Komodor repository as it should.

Screenshot 2023-10-02 at 8 35 00 AM
shivaabhishek07 commented 11 months ago

It is working when you click the star button which is just beside the GitHub logo. But it should change to get redirected when you click on GitHub logo..

7h3-3mp7y-m4n commented 11 months ago

That's my point. Can I work on this ? @shivaabhishek07

shivaabhishek07 commented 11 months ago

Yeah, you can go ahead and fix this issue. But currently, Komodor has a lack of maintainers(I think) since their last PR merged in March. Once try contacting @nirsht

7h3-3mp7y-m4n commented 11 months ago

okay @shivaabhishek07 .

7h3-3mp7y-m4n commented 11 months ago

I reached @nirsht and I couldn't get any response . So I'm thinking to raise a pr and left it for review .. what you say @shivaabhishek07 ?

shivaabhishek07 commented 11 months ago

Yeah @7h3-3mp7y-m4n , it's better to raise a PR. Maintainers will take care of whether including that feature or not..

7h3-3mp7y-m4n commented 11 months ago

@shivaabhishek07 got it .