search

komola / node-zxing

Node.JS wrapper for ZXing
24 stars 11 forks source link

multiline output is not supported #5

Open matthiasg opened 9 years ago

matthiasg commented 9 years ago

added a pull-request for that https://github.com/komola/node-zxing/pull/6

amtdevops commented 5 years ago

have you mreged it to master branch?

matthiasg commented 5 years ago

@amtdevops not sure what you mean .. i did base my change on the master yes but that was 4 years ago :) Looks still current of course since the master did not change since then.

dibishks commented 5 years ago

@matthiasg but the code not working its still returns single barcode code when I provide 'multi: false'

While checking the master code I can see that 'qrcode' variable declared as string and loop breaks when it finds the first match. Can you fix this issue

https://github.com/komola/node-zxing/blob/master/lib/main.js#L30 https://github.com/komola/node-zxing/blob/master/lib/main.js#L39

matthiasg commented 5 years ago

@dibishks I am not the maintainer of this project and have no access to it. The change is quite trivial as you identified already. Just check the code out and change it to return all codes detected