search

komoot / photon

an open source geocoder for openstreetmap data
Apache License 2.0
1.83k stars 278 forks source link

Additional languages & v0.4.0 - Possible regression #691

Closed macolu closed 1 year ago

macolu commented 1 year ago

With Photon 0.3.5, in order to customize language list, you only had to specify your list at import step (with -languages attribute).

Then, when starting Photon, you didn't have to provide language list anymore. Photon fetched list from internal DATABASE_PROPERTIES ES document.

With 0.4.0, this no longer works. You need to specify language list a second time, when starting Photon instance. Otherwise you're back with default language list (or more precisely, intersection between default list and list defined at import).

I think this has been introduced in 5290f8be. By moving default list in CommandLineArgs, it's used in both import and run contexts.

Looks like a regression to me

Thanks

lonvia commented 1 year ago

Thanks for pointing to the right commit. Can you give #693 a quick test to see if it fixes things for you?

macolu commented 1 year ago

Just tested your PR, issue is fixed for me, it brings back previous behavior.

Thanks a lot!

lonvia commented 1 year ago

Thanks for testing. New release is on the way.