search

komoot / photon

an open source geocoder for openstreetmap data
Apache License 2.0
1.83k stars 278 forks source link

Update to Elastic 8, use external cluster #767

Closed alpoi-x closed 3 weeks ago

alpoi-x commented 6 months ago

This PR makes some major changes to support modern Elasticsearch, decoupling the cluster from import and search features. My company tasked me with adapting Photon such that we can host the cluster externally with ElasticCloud. We now have this working in our dev environment, and plan to ship to production in the new year.

No expectations from me (it's a huge set of changes and will break any existing deployment), but I wanted to contribute nonetheless in-case you wanted to use or take ownership of any of the changes.

Being able to deploy externally on an updated ES version has been huge for us in terms of performance and cost. Hopefully it will be useful to others too!

NB: tests probably broken

phamtai97 commented 4 months ago

Any update for PR? Has this update changed the logic of search of Photon that affects search results or change logic to connect to external ES? Tks for your PR. We also want to deploy external ES.

lonvia commented 4 months ago

This PR has mixed in too many other new features and is missing a solution for the tests. Those are blockers for merging. I'm leaving the PR open for now, given that ES 8 is requested a lot and people might want to play with it.

phamtai97 commented 4 months ago

@lonvia Do you have plans to test this PR? I just fast review to changed files in this PR, I see the changes that seem do not related to logic search (indexes, change query logics). @alpoi-x Do you list main ideas for your changes?

lonvia commented 3 weeks ago

Closing this, as we will go the OpenSearch route. Thank you for sharing your efforts.