search

komposable / komponent

An opinionated way of organizing front-end code in Ruby on Rails, based on components
http://komponent.io
MIT License
427 stars 31 forks source link

content_for / yield is not working across components #111

Closed stevschmid closed 6 years ago

stevschmid commented 6 years ago

Apparently this was adressed earlier (Issue https://github.com/komposable/komponent/issues/19, PR https://github.com/komposable/komponent/pull/21) but it seems the involving view_flow line https://github.com/komposable/komponent/blob/dde02be9d08988e65c31b4c498e4f9440775a668/lib/komponent/komponent_helper.rb#L11-L15 didn't survive the refactoring into the ComponentRenderer https://github.com/komposable/komponent/blob/74568b7346d08a4dc750525e107f350b3260c72d/lib/komponent/component_renderer.rb#L41-L46

Spone commented 6 years ago

Hi @stevschmid thanks for the report!

@florentferry can you confirm?

Spone commented 6 years ago

Hi @stevschmid thanks for your patience while we review your PR!

Spone commented 6 years ago

Thanks for your contribution @stevschmid!

stevschmid commented 6 years ago

Thanks for merging 👍