Fix content_for & yield across components - Githubissues

komposable / komponent

An opinionated way of organizing front-end code in Ruby on Rails, based on components

http://komponent.io

MIT License

427 stars 31 forks source link

Fix content_for & yield across components #112

Closed stevschmid closed 6 years ago

stevschmid commented 6 years ago

Fixes #111

Not an expert in ActionView matters, so I'm not sure if this is the cleanest solution. I made view_flow in the ComponentRenderer optional to be backwards compatible if called without helper. Also added a test to prevent such a regression in the future.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 535

4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 99.187%

Files with Coverage Reduction	New Missed Lines	%
lib/komponent/railtie.rb	1	95.65%
<!--	Total:	1		-->

Totals
Change from base Build 504:	-0.8%
Covered Lines:	122
Relevant Lines:	123

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 512

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 504:	0.0%
Covered Lines:	120
Relevant Lines:	120

💛 - Coveralls

florentferry commented 6 years ago

Hi @stevschmid, thanks for your PR. I should review it soon.