komposable / komponent

An opinionated way of organizing front-end code in Ruby on Rails, based on components
http://komponent.io
MIT License
426 stars 31 forks source link

remove view_renderer chain assigment #134

Closed agungyuliaji closed 5 years ago

agungyuliaji commented 5 years ago

close #133 close #118

i don't know if this change will affect to another part, but this quick fix it's work on my end

there is no view_renderer= in Rails 6.0.0.beta3

Spone commented 5 years ago

Hi @agungyuliaji, thanks for contributing!

As you can see in Travis CI, the tests do not pass, it's breaking some features. Do you want to try to fix it another way?

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 767


Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 767


Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 767


Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 802


Totals Coverage Status
Change from base Build 801: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
robink commented 5 years ago

This has side effects on Rails 5.2, it breaks, certainly among others things, rendering outside komponent if komponent is used.

= c "my_komponent"
= render partial: "my_standard_partial" // will never be found