search

komposable / komponent

An opinionated way of organizing front-end code in Ruby on Rails, based on components
http://komponent.io
MIT License
427 stars 31 forks source link

Update InstallGenerator to use eager loading #136

Closed Spone closed 5 years ago

Spone commented 5 years ago

close #121

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 800

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 783

Totals Coverage Status
Change from base Build 755: 0.0%
Covered Lines: 180
Relevant Lines: 181
💛 - Coveralls
nicolas-brousse commented 5 years ago

@Spone LGTM, but why not profit we are releasing the v3 to have this code directly inside the gem as many other gems do?

Could be nice to have the issue #121 or this PR noticed in the changelog too.

Spone commented 5 years ago

@Spone LGTM, but why not profit we are releasing the v3 to have this code directly inside the gem as many other gems do?

Let's create another issue for this: #139

Could be nice to have the issue #121 or this PR noticed in the changelog too.

Done.

Can you please do a github review so I can merge?