search

komposable / komponent

An opinionated way of organizing front-end code in Ruby on Rails, based on components
http://komponent.io
MIT License
427 stars 31 forks source link

Compatibility with Stimulus 1.0 #46

Closed Spone closed 6 years ago

Spone commented 6 years ago

I updated the JS template to support the latest version of Stimulus. See here: https://stimulusjs.org/handbook/installing#using-webpack

Spone commented 6 years ago

By the way I'm not sure if this line is needed: https://github.com/komposable/komponent/blob/aae4b24a3562c3e7c7852e61555acf3f9eb91bca/lib/generators/component/templates/stimulus_controller_js.erb#L2

We already import the CSS in https://github.com/komposable/komponent/blob/stimulus-1.0/lib/generators/component/templates/js.erb

Spone commented 6 years ago

@sigmike you can merge