search

komputing / KEthereum

Kotlin library for Ethereum
MIT License
344 stars 72 forks source link

Multichain support for ENS resolution #104

Open Arachnid opened 3 years ago

Arachnid commented 3 years ago

It'd be great if the ENS integration in kethereum supported resolving addresses other than Ethereum addresses, as per EIP 2304. At least Bitcoin and Bitcoin Cash support would be an amazing start.

We have a JS library that encodes and decodes different address types here, for reference: https://github.com/ensdomains/address-encoder

brantlymillegan commented 3 years ago

@ligi thanks tagging it so fast. Given your tag "help wanted", any objections to us putting this on Gitcoin with a bounty?

ligi commented 3 years ago

tbh I had some bad experiences with bounties in the past. If people just write code for the money it can be worse as when they actually write it with the intent to use it. This is also part of the reason why I tagged it with "help wanted". This is a functionality I do not see me using on my own - and Ideally the feature is done by someone actually having a use case for it. But I am also open to a bounty - just my 2cents here.

brantlymillegan commented 3 years ago

Got it. Background on our request: the Bitcoin.com Wallet requested a Kotlin library from us for their ENS integration, and they support BTC, BCH, and ETH, hence our request. (right now, they're using a library maintained by Unstoppable Domains to integrate ENS, which is bad given the conflict of interest, but it supports ENS wrong anyway)

ligi commented 3 years ago

Great to hear. So the ideal thing would be if they contribute the feature. Happy to review the PR and merge it. And if they do not want to do so I am also OK with a bounty. I just do not see myself doing it for reasons stated above and also time reasons.