komputing / KEthereum

Kotlin library for Ethereum
MIT License
350 stars 73 forks source link

Multiplatform setup #63

Closed RiccardoM closed 5 years ago

RiccardoM commented 5 years ago

Disclaimer

This is still WIP. I've opened it to let people know I'm working on this. Any feedback is appreciated.

Notes

First attempt to create a multiplatform project.

Currently revisited modules:

Missing modules to revisit:

Related issues

Closes #22 Closes #31 Closes #61 Closes #62

RiccardoM commented 5 years ago

@ligi The conversion is 99% done. We need to change the CI in order to execute the gradle check command to test everything automatically. Also there are some tests that are failing due to some errors. Can we look at them and try to fix them?

Note. In order to make this library 100% multiplatform, I had to copy/paste the Walleth/HEX and Wallet/SHA3 classes inside the project. To make them usable by this library, we need to convert them to multiplatform too.

ligi commented 5 years ago

We need to change the CI in order to execute the gradle check command to test everything automatically.

this is as easy as adding a "check" to "stages" in here: https://github.com/walleth/kethereum/blob/master/.ci/kontinuum.json

but what would it execute more than ./gradlew test is doing

Can we look at them and try to fix them?

am currently quite busy - so if I need to have a look it will take some time

Note. In order to make this library 100% multiplatform, I had to copy/paste the Walleth/HEX and Wallet/SHA3 classes inside the project. To make them usable by this library, we need to convert them to multiplatform too.

is there really no other way? this would be quite ugly imho - perhaps a subproject? Really hope there is another way

RiccardoM commented 5 years ago

@ligi Understanding that you have not much time in order to maintain this project right now, my company decided to fork a new project from here and start working on it.

Unfortunately we need to have a multiplatform project that can be published properly on Bintray, and thus we had to revisit all the code structure and publishing pipeline. This, along with the fact that we will need to audit the codebase, has made us decide to start this new project, without forgetting and mentioning your work inside it.

If you will you are super welcome to help up improve the project. From our part we will maintain the documentation and try implementing new features that are useful for us.

That being said, I'm closing this PR right now being it outdated.

ligi commented 5 years ago

I have time to maintain this project and review pull requests. My mentioning having no time was regarding:

Also there are some tests that are failing due to some errors. Can we look at them and try to fix them?

A bit sad this diverges now as I think this will be hard to converge again in the future.

RdeWilde commented 3 years ago

Why exactly is this issue closed? @RiccardoM

Any other efforts for multiplatform?