Multiplatform implementation

komputing / KHash

Different hash functions in Kotlin (SHA3 with Keccak and Shake variants, sha256, ripemd160)

MIT License

54 stars 10 forks source link

Multiplatform implementation #7

Closed RiccardoM closed 5 years ago

RiccardoM commented 5 years ago

Changes

Changed the whole code architecture in order to allow multiplatform usage of the library.

Additions

Added the ripemd160 module
Added the keccak module
Added the extensions module

Removals

I had to remove Gradle Witness as I don't know how to make it work inside multiplatform projects

RiccardoM commented 5 years ago

All the tests should pass correctly and the PR should be ready to be merged

RiccardoM commented 5 years ago

I see failing tests:

khash.sha256.Sha256Tests > testHashRawBytes FAILED
    java.lang.AssertionError at Sha256Tests.kt:36

khash.sha256.Sha256Tests > testDigest FAILED
    java.lang.AssertionError at Sha256Tests.kt:26

Should be fixed now. I think this was due to a wrong mockkObject call that made the Sha256 object return a different result in subsequent tests. With the last commit this should be fixed.

ligi commented 5 years ago

dam - just saw now after the merge that the module structure is wrong - sha256 is in sha3 - this is wrong - can you fix @RiccardoM

RiccardoM commented 5 years ago

@ligi Implemented the fix inside GH-8