komuw / naz

naz is an async SMPP client.

https://komuw.github.io/naz/

MIT License

39 stars 12 forks source link

Issues/188: data_coding should not be applied to all C-Octet String fields #190

Closed komuw closed 4 years ago

komuw commented 4 years ago

Thank you for contributing to naz.
Every contribution to naz is important.

Contributions are under the MIT License.

Answer the following questions,

What(What have you changed?)

BugFix, data_coding should not be applied to all fields that are of type C-octet string
- Have the naz messsage protocol only use utf8 for encoding/decoding

Why(Why did you change it?)

fixes: https://github.com/komuw/naz/issues/188
A C-Octet string, is a series of ASCII characters terminated with the NULL character.
see; section 3.1 of SMPP spec
Thus we need to encode any field that is a C-Octet strings as ascii and also terminate them with NULL char(chr(0).encode())
eg, system_id.encode("ascii") + chr(0).encode()
Also they should be decoded as such; message_id.decode('ascii')

References: