komuw / naz

naz is an async SMPP client.
https://komuw.github.io/naz/
MIT License
39 stars 12 forks source link

Set connection state to CLOSED after unbind_and_disconnect #211

Closed theLastOfCats closed 4 years ago

theLastOfCats commented 4 years ago

Which version of python are you using?

3.8.1

What operating system and version of operating system are you using?

MacOS 10.15.6

What version of naz are you using? naz-cli --version

0.8.0

What did you do? (be as detailed as you can)

I restart container with smpp simulator, and try to send message after simulator start.

What did you expect to see/happen/not happen?

SMPP client reconnect and successful message delivery

What did you actually see/happen?

SMPP client stuck after one try of reconnect

Paste here the log output generated by naz, if any. Please remember to remove any sensitive items from the log before pasting here.

theLastOfCats commented 4 years ago

Explicitly set connection state to CLOSED after https://github.com/komuw/naz/blob/master/naz/client.py#L1782 fixes the problem

theLastOfCats commented 4 years ago

Since problem related to recieve_data lifecycle, we can simply call re_establish_conn_bind and it will set connection state to CLOSED

theLastOfCats commented 4 years ago

@komuw when do you plan to release a new version?

komuw commented 4 years ago

Hi. I plan to release by the end of this month.

On Fri, 18 Sep 2020 at 11:48, Shagit Ziganshin notifications@github.com wrote:

@komuw https://github.com/komuw when do you plan to release a new version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/komuw/naz/issues/211#issuecomment-694742146, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHMWUNTISCC5QQFDCIEGGDSGMNFDANCNFSM4RHUMMRQ .

-- Thanks,

KomuW. https://www.komu.engineer/about

komuw commented 3 years ago

Hello @theLastOfCats try the beta version: https://pypi.org/project/naz/0.8.1b0/

Let me know if it works okay so that I can release the final version.

komuw commented 3 years ago

ping @theLastOfCats

theLastOfCats commented 3 years ago

Hi!

It works fine, you can release final version. Thanks!

komuw commented 3 years ago

https://pypi.org/project/naz/0.8.1/