komuw / ong

ong, is a Go http toolkit.
MIT License
16 stars 4 forks source link

issues/289: move acme handler to ong/middleware. #290

Closed komuw closed 1 year ago

komuw commented 1 year ago
  1. Fixes: https://github.com/komuw/ong/issues/289
  2. https://letsencrypt.org/docs/challenge-types/
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 90.10% and project coverage change: +1.27 :tada:

Comparison is base (4022a8c) 77.32% compared to head (59b9f01) 78.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== + Coverage 77.32% 78.59% +1.27% ========================================== Files 36 38 +2 Lines 3457 3480 +23 ========================================== + Hits 2673 2735 +62 + Misses 650 615 -35 + Partials 134 130 -4 ``` | [Impacted Files](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu) | Coverage Δ | | |---|---|---| | [server/tls\_conf.go](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu#diff-c2VydmVyL3Rsc19jb25mLmdv) | `49.25% <29.41%> (-8.18%)` | :arrow_down: | | [server/server.go](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu#diff-c2VydmVyL3NlcnZlci5nbw==) | `75.10% <58.82%> (-0.31%)` | :arrow_down: | | [internal/dmn/dmn.go](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu#diff-aW50ZXJuYWwvZG1uL2Rtbi5nbw==) | `100.00% <100.00%> (ø)` | | | [middleware/acme.go](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu#diff-bWlkZGxld2FyZS9hY21lLmdv) | `100.00% <100.00%> (ø)` | | | [middleware/middleware.go](https://app.codecov.io/gh/komuw/ong/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Komu+Wairagu#diff-bWlkZGxld2FyZS9taWRkbGV3YXJlLmdv) | `100.00% <100.00%> (+4.54%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.