Closed komuw closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
da241d7
) 72.93% compared to head (9940e96
) 69.65%. Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is done because Go v1.22 made a breaking change where the alphabet passed into
base64.NewEncoding(alphabet)
should no longer contain duplicate[1] characters.The alphabet previously used by
ong/id
contained duplicates in order to reduce ambiguity.In this PR we change to
base32
, since the alphabet size is smaller thanbase64
and we can thus eliminate ambiguity from it without using duplicate characters.Example of the id's generated now;