komuw / sewer

Let's Encrypt(ACME) client. Python library & CLI app.
MIT License
145 stars 54 forks source link

Add --acme_timout option to sewer-cli #188

Closed mmaney closed 4 years ago

mmaney commented 4 years ago

This is the enhancement @menduo presented in #154 lightly revised. Biggest change is to the option name, which is --acme_timeout rather than just --timeout because there are already other timeouts that may need to be accessible through a sewer-cli option.

codecov[bot] commented 4 years ago

Codecov Report

Merging #188 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          18       18           
  Lines        1133     1133           
=======================================
  Hits          991      991           
  Misses        142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c3cd1f...3ef0702. Read the comment docs.

menduo commented 4 years ago

👍