search

komuw / sewer

Let's Encrypt(ACME) client. Python library & CLI app.
MIT License
145 stars 52 forks source link

Add **kwargs to all legacy provider classes, pass to super().__init__ #189

Closed mmaney closed 4 years ago

mmaney commented 4 years ago

This allows some of the new facilities that are setup through keyword args through the drivers to operate in legacy (not alias, needs other changes).

codecov[bot] commented 4 years ago

Codecov Report

Merging #189 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          18       18           
  Lines        1133     1133           
=======================================
  Hits          991      991           
  Misses        142      142
Impacted Files Coverage Δ
sewer/dns_providers/acmedns.py 86.84% <100.00%> (ø)
sewer/dns_providers/aliyundns.py 84.46% <100.00%> (ø)
sewer/dns_providers/auroradns.py 88.00% <100.00%> (ø)
sewer/dns_providers/cloudflare.py 93.15% <100.00%> (ø)
sewer/dns_providers/cloudns.py 75.00% <100.00%> (ø)
sewer/dns_providers/common.py 95.83% <100.00%> (ø)
sewer/dns_providers/dnspod.py 94.54% <100.00%> (ø)
sewer/dns_providers/duckdns.py 92.85% <100.00%> (ø)
sewer/dns_providers/gandi.py 88.57% <100.00%> (ø)
sewer/dns_providers/hurricane.py 70.45% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56d73a3...8fc1a6b. Read the comment docs.

mmaney commented 4 years ago

...playing little games, like not looking at it for a while, then looking... to see if I still liked it. I did.