Closed komuw closed 5 years ago
Merging #46 into master will increase coverage by
0.25%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 76.03% 76.28% +0.25%
==========================================
Files 14 14
Lines 797 797
==========================================
+ Hits 606 608 +2
+ Misses 191 189 -2
Impacted Files | Coverage Δ | |
---|---|---|
wiji/task.py | 77.51% <100%> (ø) |
:arrow_up: |
wiji/worker.py | 81.01% <100%> (+0.63%) |
:arrow_up: |
wiji/watchdog.py | 84.84% <0%> (+1.51%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 83af257...8b6217d. Read the comment docs.
Thank you for contributing to wiji.
Every contribution to wiji is important.
Contributor offers to license certain software (a “Contribution” or multiple “Contributions”) to wiji, and wiji agrees to accept said Contributions, under the terms of the MIT License. Contributor understands and agrees that wiji shall have the irrevocable and perpetual right to make and distribute copies of any Contribution, as well as to create and distribute collective works and derivative works of any Contribution, under the MIT License.
Now,
What(What have you changed?)
wiji.task.WijiRetryError
We replace it with atask.Task._RETRYING
boolean.Why(Why did you change it?)
WijiRetryError
makes it harder to write tests and it also looks like an antipatternReferences: