Closed komuw closed 5 years ago
Merging #49 into master will increase coverage by
2.29%
. The diff coverage is68.62%
.
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 76.28% 78.57% +2.29%
==========================================
Files 14 14
Lines 797 859 +62
==========================================
+ Hits 608 675 +67
+ Misses 189 184 -5
Impacted Files | Coverage Δ | |
---|---|---|
cli/cli.py | 56.25% <12.5%> (-5.16%) |
:arrow_down: |
wiji/worker.py | 78.57% <50%> (-2.45%) |
:arrow_down: |
wiji/task.py | 76% <74.64%> (-1.52%) |
:arrow_down: |
wiji/app.py | 78.94% <90.9%> (-1.06%) |
:arrow_down: |
wiji/watchdog.py | 83.33% <0%> (-1.52%) |
:arrow_down: |
cli/utils/load.py | 88.88% <0%> (+33.33%) |
:arrow_up: |
cli/utils/sig.py | 89.18% <0%> (+70.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 06db93a...edba50b. Read the comment docs.
Thank you for contributing to wiji.
Every contribution to wiji is important.
Contributor offers to license certain software (a “Contribution” or multiple “Contributions”) to wiji, and wiji agrees to accept said Contributions, under the terms of the MIT License. Contributor understands and agrees that wiji shall have the irrevocable and perpetual right to make and distribute copies of any Contribution, as well as to create and distribute collective works and derivative works of any Contribution, under the MIT License.
Now,
What(What have you changed?)
No longer require task instances in order to start running
Previously, in order to use
wiji
/wiji-cli
;wiji.task.Task
wiji.app.App
which would take a list of class instances ofwiji.task.Task
This means, that you would be forced to create task instances even before you know where you want to use them.In the new dispensation, the steps neccessary are;
wiji.task.Task
that takes a broker and queue_name as attributes.wiji.app.App
which will take a list of classes ofwiji.task.Task
(NOT class instances)Why(Why did you change it?)
wiji
easier to useReferences: