search

konadave / com.klangsoft.overrides

Other
4 stars 4 forks source link

Fix using depreciated functions #3

Closed erawat closed 1 year ago

erawat commented 3 years ago

CiviCRM changed the way they handle warning for using a deprecated function. See this PR .

The changed will always throw use deprecated warning if the deprecated function is used in anywhere, for example, Drupal module, CiviCRM extension. This would not have an issue we install the extension / module via user interface. However, when we use Drush site-install command to install the Drupal site that ship with a Drupal profile that install the extension when creating a site.

Any module or extension that use CiviCRM's deprecated function in the installation hook, upgrade hook, the E_USER_DEPRECATED warning will throw during installation, but Drush handles deprecated messages as an error rather than a warning.

This PR migrating deprecated functions which are CRM_Core_BAO_Setting::getItem() and CRM_Core_BAO_Setting::setItem() to use Civi::settings() as per CiviCRM recommendation.

erawat commented 3 years ago

Hello, is it possible to get this PR merged?

Thanks.

Erawat

konadave commented 1 year ago

Not applicable to new version.