search

konadave / com.klangsoft.overrides

Other
4 stars 4 forks source link

Diff against currently installed version of core file #7

Open wmortada opened 1 year ago

wmortada commented 1 year ago

Hi @konadave, thanks for creating a new version of this extension. We use it on a number of sites and find that it is a useful tool.

The new version is great, but I think it could do with one more option. Would it be possible to add an option that shows a diff of the override file against the current version of the CiviCRM core file? This could be useful in some cases, e.g. if the extension release date is incorrect or you've just updated the override file to include the latest changes from core (but not the extension release date).

konadave commented 1 year ago

@wmortada First off, thanks for the feedback.

I don't think I understand the use case.

There are already options to compare against the version of Civi that was current as of the release date of the extension, and to compare against the currently installed version of Civi.

You want to be able to compare against the latest version of Civi, which is presumably newer than the installed version? I don't know that it's wise to include future (from the POV of the installation) changes in an override file. What happens when those changes depend on other changes to core files that are not overridden by the extension?

wmortada commented 1 year ago

Hi @konadave, thanks for replying and sorry if I was unclear. I meant a diff against the currently installed version. I couldn't see that option (or perhaps it was disabled?)