Closed kn-ms closed 9 months ago
using plugin with tslint, so the pipelines will check if all consistent for a pr
Hm, I missed that. So, prettier will run as part of tslint? I don't see tslint being supported here https://prettier.io/docs/en/integrating-with-linters. If it'll run all the same rules, then you can disregard (2) from my previous comment.
using plugin with tslint, so the pipelines will check if all consistent for a pr
Hm, I missed that. So, prettier will run as part of tslint? I don't see tslint being supported here https://prettier.io/docs/en/integrating-with-linters. If it'll run all the same rules, then you can disregard (2) from my previous comment.
there is a tslint plugin which I have hooked up, so tslint will run prettier behind the scenes and report prettier errors as well: https://www.npmjs.com/package/tslint-plugin-prettier
I have no good network connection at the moment, will add prettier to the suggestions mid next week.
Hi @kondratyev-nv ,
I'm always strugling to be consistent on code formatting, and tend to use prettier on save for ts/js projects. I see there are some inconsitencies in this code base as well and would be too worky too fix up many thing just with tslint. So I hooked up prettier (as it has opinions I do not need to think on) for the repo.
npm run format
to get src and test formattedIf you are ok with this please take this pr. Thx K