realizing the spirit using IPFs

[sevu]

A while ago I experimented with the image path functions, especially the new sepia function. What do you think about it?

(this PR has similar issues like the other one with the variations, let's don't focus on that)

[sevu]

Good catch. I think inherit=yes is not related to the problem with the help pages ( I thought so in the beginning) It's like, if we have hide_help=yes in the base unit, the variation will show the base unit's help entry.

[konecnyjakub]

I just ran Wesnoth and it screamed at me :). (talking about the typo here)

[sevu]

Let's add this to milestone 2.0, since it's all about the 1.13 sepia function.

[konecnyjakub]

Well, you also made the spirit a variation. If you use inherit=yes for it, it might be worth to have this in 1.3. But if you are not going to do anything with this soon, I will change the milestone.

[sevu]

I'll have a look at this next. I actually thought about reverting the use of a variation because of the hide_help issue.

[konecnyjakub]

Oh, you pushed a new version. Did not notice. I will take a look tomorrow.

[sevu]

Now I understand that function. About the standing animation, I think the shimmering effect can need more finetuning, but for now I leave it as is. There are three places where the name & variation_name are used

• the variation_name is shown in the variation line of the base unit. (and looks broken if it isn't set)
• the variation_name is shown under the name in the help page of the variation
• if no "name" is set it won't be shown on the right side when the unit is selected

I think Spirit fit's good.

I will take a look at the other PR soon.

[konecnyjakub]

So should I merge this now? If so, please squash the commits.

[sevu]

Yes, quashed it. I think there's an option for squash merge too, though I never used it.

Edit: btw, what do you think about the do_not_list attribute? I mostly set it to yes.

[konecnyjakub]

The wiki says this:

Not used by the game, but by tools for browsing and listing the unit tree. If this is 'yes', the unit will be ignored by these tools.

The only such tool I know of is the script used to generate units.wesnoth.org. Given that this unit type (not variation) appears only in a cutscene, it is not important to have it listed there.

[sevu]

My pleasure ;)