Closed sevu closed 7 years ago
There should be now 3 more translatable strings for the difficulties because the brackets are inserted by the game in 1.13.
For playing in 1.13 one would have to run the wmllint script included with 1.13, because the location of the portrait images in mainline did change.
What a coincidence! I also started to update the campaign for Wesnoth 1.13 a while ago. But I will examine this anyway.
I am not much concerned about the new translatable strings, they are just a bit different from the originals. I should be able to update them myself :) .
What a coincidence. But there is not much more one could do for 1.12 without droping 1.12 compatibility. About the CAMPAIGN_DIFFICULTY macro i just found out myself when SotA became mainlined. As for the data/..., this is needed if we remove the binary path above.
Yes, easy job :)
For data, silly me, of course you are right.
I'm quite happy about the clean code style in this campaign.
Merged, thank you :) .
Oh and I think that if you do another PR, I will mention you in credits and probably give you push access to this repository :) .
You're welcome. But for now I have nothing in mind I that I would change.
removed need to define the binary path outside of the ifdef removed ellipses (not needed by default anymore since 1.12) wmlindet changed the formating a bit too.
What I noticed too and didn't change: The Ghast uses the same id than the mainline one, which drops a warning on stderr.