konflux-ci / architecture

Technical and Architecture documents
https://konflux-ci.dev/architecture/
18 stars 70 forks source link

First draft of ADR on related pipelines #114

Closed arewm closed 1 year ago

arewm commented 1 year ago

Part of the support for OLM operators within AppStudio is ensuring that component relationships can be maintained. If there are components that are dependent on each other, then a change in one image should be able to precipitate a change in another image to ensure that the initial change can be fully tested.

This PR is related to #113 as both are proposed solutions to the same underlying problem.

rcerven commented 1 year ago

I like https://github.com/redhat-appstudio/book/pull/113 more than https://github.com/redhat-appstudio/book/pull/114

Also I think it is benefit to have dependency information under Component, which is also easily accessible in OCP

Also with UI for setting up those dependencies it would be more user friendly

Lastly probably also easier for debugging

Roming22 commented 1 year ago

@vdemeester Could you give your opinion on the impact on PaC (do the changes would make sense and be likely to be adopted by the project, what are their complexity)?

chmouel commented 1 year ago

paac is not going to implement rhtap specific logic in its code.

If there is a request on a specific feature of paac out of this ADR, it would be nice to extract the exact feature you need to understand what you want to do from paac.

Trying to understand what is your goal, is to be able to compose a pipelinerun out of multiple repository? would https://issues.redhat.com/browse/SRVKP-3020 will be helping you? where we give you the ability to give us the PipelineRun that needs to be run.

If you need something else please let us know but bear in mind that i am not aware of how appstudio works and this discussion would be easier if we can focus the exact feature needed from paac.

arewm commented 1 year ago

Thanks for the reviews on this ADR. We decided to go with the ComponentReferences (#113) approach instead.