konflux-ci / architecture

Technical and Architecture documents
https://konflux-ci.dev/architecture/
18 stars 67 forks source link

docs(STONEINTG-496): remove the link for unused tasks #120

Closed hongweiliu17 closed 1 year ago

hongweiliu17 commented 1 year ago

Signed-off-by: Hongwei Liu hongliu@redhat.com

hongweiliu17 commented 1 year ago

@dirgim @MartinBasti @sonam1412 PTAL

hongweiliu17 commented 1 year ago

@arewm @mattreid Could you help review this PR? Thanks!

mattreid commented 1 year ago

My initial reaction is I wasn't expecting to still see them listed here at all, but I don't have much context on this Security Guild page, so continuing to list them may be fine. From the description at the top, it sounds like anything listed in this page has our endorsement, so listing them without any context could lead readers to think that they're ready to use. Another option could be to mention that they were previously included, but removed in favor of snyk due to performance issues that needed more investigation, that way we have a record that they were deemed acceptable at one point, and with more work, could maybe be an option for other teams.

Andrew is on vacation starting today for 2 weeks, so if you'd like another review, @ralphbean might be able to take a look for a more technical opinion.

hongweiliu17 commented 1 year ago

Thanks for the comment and review.