search

konflux-ci / architecture

Technical and Architecture documents
https://konflux-ci.dev/architecture/
18 stars 67 forks source link

add deletecollection verb #129

Closed yangcao77 closed 1 year ago

yangcao77 commented 1 year ago

See discussion in slack thread: https://redhat-internal.slack.com/archives/C02FANRBZQD/p1692011366722619

For issue https://issues.redhat.com/browse/RHTAPBUGS-595

naftalysh commented 1 year ago

You need also allow the deletecollection verb to the componentdetectionquery object The CDQ will eventually be garbage collected by HAS. Deleting the Application will not delete the CDQ

yangcao77 commented 1 year ago

@naftalysh in the ADR doc, components and componentdetectionqueries are under Component. So it's already included, thx. https://github.com/redhat-appstudio/book/blob/7eb7c2dfce0b56491279340315268923c0c22339/ADR/0011-roles-and-permissions.md?plain=1#L69