search

konflux-ci / architecture

Technical and Architecture documents
https://konflux-ci.dev/architecture/
18 stars 70 forks source link

Add kind annotation to IntegrationTestScenario #138

Closed zregvart closed 1 year ago

zregvart commented 1 year ago

To better communicate with the UI, rather than to rely on heuristics or ad-hoc values, this introduces the explicit annotation on the IntegrationTestScenario that holds its kind. First kind value is the enterprise-contract, others can be added as needed.

cc @rohitkrai03, @sahil143

Ref. https://issues.redhat.com/browse/HACBS-2546

zregvart commented 1 year ago

Converting to draft, this doc should speak to what is the current version and the annotation will be in a (near) future version.

dirgim commented 1 year ago

We accept the proposed draft, this can be merged after the implemented changes are in place.

amfred commented 1 year ago

We accept the proposed draft, this can be merged after the implemented changes are in place.

Makes sense to me.

zregvart commented 1 year ago

With https://github.com/openshift/hac-dev/pull/828 merged the test.appstudio.openshift.io/kind=enterprise-contract annotation is now in use.