search

konflux-ci / architecture

Technical and Architecture documents
https://konflux-ci.dev/architecture/
18 stars 70 forks source link

ADR to enable chaos testing of apps #171

Closed yogananth-subramanian closed 5 months ago

yogananth-subramanian commented 8 months ago

The objective of this ADR is to propose a way to enable the end user to run chaos tests for his app as part of integration testing.

yogananth-subramanian commented 7 months ago

cc @psuriset @chaitanyaenr

yogananth-subramanian commented 7 months ago

The context around the usefulness of chaos testing here is good, but kind of general. I'm not sure how this applies to konflux concretely. Can you refactor the ADR to be more specific about the decision and the impacts you think that it will have on konflux and the konflux development process?

Hello @ralphbean I apologize for being unclear. The purpose of the ADR is to allow Konflux users to run chaos tests as part of IntegrationTestScenarios.. As part of the ADR, we would like to propose that the service account created as part of integration-service be used to access thanos-querier-openshift-monitoring or prometheus-k8s-openshift-monitoring endpoints. The change it would cause would be that the service account would now be able to run promQL queries. Let me change the ADR and update the proposal.

ralphbean commented 7 months ago

@amisstea, @dirgim can I request your review on this? It is related to both integration service and https://github.com/redhat-appstudio/architecture/pull/172

yogananth-subramanian commented 5 months ago

Hello @ralphbean @amisstea @dirgim I have revised the ADR based on the discussion during the arch call to incorporate the utilization of ephemeral clusters. It would be wonderful if you could provide your input on the updated ADR.

yogananth-subramanian commented 5 months ago

Hello @amisstea , I have revised the ADR based on your suggestion and have also taken out some technical implementation that might not be relevant for the decision-making. It would be wonderful if you could provide your input on the updated ADR.

yogananth-subramanian commented 5 months ago

Hello @amisstea @dirgim @ralphbean I would like to thank you for your patience review and helpful comments. Have updated the dat to today's date and set the status to Accepted.