feat(KONFLUX-2072): prepare the pkg to be able to detect issues outside e2e workflow - Githubissues

konflux-ci / qe-tools

Contains various useful commands for processing test data

Apache License 2.0

0 stars 9 forks source link

feat(KONFLUX-2072): prepare the pkg to be able to detect issues outside e2e workflow #85

Closed dheerajodha closed 5 months ago

dheerajodha commented 6 months ago

Improved the handling of iterator of e2e directory. The changes ensure that the iterator's pointer is not advanced when checking for iterator.Done, preventing potential data loss.
When the first call to it.Next() returns iterator.Done, that means there's no files found within the current directory with given prefix.
This implies there are no files present within the directory that's supposed to store artifacts related to e2e tests.
So, we initialise a new iterator for a new directory with prefix that points to "build-log.txt" file. And accordingly we init the maps.
This commit also refactors some logic to move them inside a function.

Signed-off-by: Dheeraj<djodha@redhat.com>

Dannyb48 commented 6 months ago

@dheerajodha looks like the action is on you now?

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dheerajodha commented 5 months ago

@dheerajodha looks like the action is on you now?

Thanks for the reminder!

Ah, I force-pushed while rebasing, didn't change the content.

dheerajodha commented 5 months ago

did you have a chance to verify the changes in both scenarios (i.e. when the input is job URL/job ID)?

Yes, I checked the changes by providing the job URL as well as the job ID and it worked as expected

psturc commented 5 months ago

ok then it's good to merge 👍