search

konflux-ci / rpm-lockfile-prototype

GNU General Public License v3.0
3 stars 10 forks source link

Ignore tags for inspecting image if digest is specified #43

Closed lubomir closed 1 month ago

lubomir commented 1 month ago

The tool can now obtain labels from a container image using skopeo. If the image is specified with both tag and digest, skopeo will fail.

This commit makes the resolver ignore the tag, so it will look up the labels based on the digest.

ckelleyRH commented 1 month ago

Great minds think alike :laughing: - your version is better than #45 in my opinion, so please feel free to close mine as duplicate and use this to resolve #44. Thanks for your help!

lubomir commented 1 month ago

You did the work, you deserve the credit :wink: I'll just update this to adjust the tests, then both can be merged.

ckelleyRH commented 1 month ago

Thanks @lubomir! If possible, can you cut a v0.7.2 release please? I would like to add in version tags at the same time as making all our containers inherit the compose of the base images. This would mean I only have to make 63 MRs, instead of 126 :smile:

lubomir commented 1 month ago

Done, there's a new tag now.