search

konform-kt / konform

Portable validations for Kotlin
https://www.konform.io
MIT License
636 stars 39 forks source link

multi platform build with kotlin 2.0.0 #106

Closed jillesvangurp closed 1 month ago

jillesvangurp commented 2 months ago

addresses #102

jillesvangurp commented 2 months ago

Let's wait for the final release for kotlin 2.0 and then update this PR.

This adds native, wasm, and other multiplatform targets.

dhoepelman commented 2 months ago

I haven't looked much at 2.0 yet. Do you know the backwards compatibility guarantees? If we compile with 2.0, what is the minimum kotlin version for users of the library? Didn't spot it in the release notes. In current main it's compiled with 1.9 and minimum kotlin user version is 1.7.

Might be that they address this in the full 2.0 release.

jillesvangurp commented 2 months ago

They continue to support older versions. I've kept the 1.7 target. So I expect things should work.

dhoepelman commented 2 months ago

Fixes #68

jillesvangurp commented 1 month ago

This is now ready to be merged now that 2.0.0 is out.

dhoepelman commented 1 month ago

Thanks!

dhoepelman commented 1 month ago

Looks like there's some more work to do to support the iOS targets

w: The following Kotlin/Native targets cannot be built on this machine and are disabled:
iosArm64, iosX64, macosArm64, macosX64, tvosArm64, tvosX64, watchosArm32, watchosArm64, watchosX64
jillesvangurp commented 1 month ago

You need xcode and a mac for that. Worked fine on my machine. But I'm not actively doing any ios development.

dhoepelman commented 1 month ago

Yeah a macos github actions runner is necessary to build the ios targets in PRs and do the ios release, that's what I meant