search

konform-kt / konform

Portable validations for Kotlin
https://www.konform.io
MIT License
636 stars 39 forks source link

change the release CI target to macos-latest #119

Closed psuzn closed 1 week ago

psuzn commented 2 weeks ago

Addresses the #118.

These are the artifacts generated when running ./gradlew publishToMavenLocal

Before After
From https://repo1.maven.org/maven2/io/konform/

344641289-70e1b81b-2559-496a-8f04-9b828796a2a9		 ./gradlew publishToMavenLocal on macos

Screenshot 2024-07-02 at 09 16 55
psuzn commented 1 week ago

Hey @dhoepelman, is there a time frame when you can review it, please?

And again, thanks for the amazing work.

dhoepelman commented 1 week ago

Hey, thanks for the pr. That was easier then I thought.

We do however also need to add macOS target as matrix together with Linux in the test workflow. If you do that I'll merge, otherwise I'll do that this week.

On Sun, Jul 7, 2024, 04:27 Sujan Poudel @.***> wrote:

Hey @dhoepelman https://github.com/dhoepelman, is there a time frame when you can review it, please?

And again, thanks for the amazing work.

— Reply to this email directly, view it on GitHub https://github.com/konform-kt/konform/pull/119#issuecomment-2212292973, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSHGLLTXYHPOEZMFL4G73ZLCRP7AVCNFSM6AAAAABKGVZMQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGI4TEOJXGM . You are receiving this because you were mentioned.Message ID: @.***>

dhoepelman commented 1 week ago

Found some time today and added it. Thanks for raising and the initial change!