kongchen / swagger-maven-plugin

JAX-RS & SpringMVC supported maven build plugin, helps you generate Swagger JSON and API document in build phase.
http://kongchen.github.io/swagger-maven-plugin/
Apache License 2.0
761 stars 451 forks source link

swagger classifier name not in line with documentation #621

Open GDeen opened 6 years ago

GDeen commented 6 years ago

https://github.com/kongchen/swagger-maven-plugin/blob/9ff0630508ba8ff7f391a5119f3f25de6792aa2c/src/main/java/com/github/kongchen/swagger/docgen/mavenplugin/ApiDocumentMojo.java#L121

Hi, the behavior was changed here, and also the documentation is no longer in line with the code: Documentation: attachSwaggerArtifact | If enabled, the generated swagger.json file will be attached as a maven artifact. The swaggerDirectory's name will be used as an artifact classifier. Default is false.

We have specified both the artifactFilename and artifactDirectory. However, now that we stepped our swagger version it no longer takes the artifactDirectory name as classifier.

We suggest to add an additional parameter and if that one is not set, default back to the old behavior (e.g. artifactDirectory).

GDeen commented 6 years ago

thank you!