kongkx / homebridge-gree-air-conditioner

Apache License 2.0
20 stars 8 forks source link

Merge Fan and Vertical Swing into HeaterCooler accessory #17

Closed ThisIsQasim closed 1 year ago

ThisIsQasim commented 1 year ago

Is your feature request related to a problem? Please describe:

Currently the plugin exposes Fan setting and Swing Mode as separate Fan and Switch accessory. This can be consolidated in to the existing HeaterCooler accessory.

Describe the solution you'd like:

Merge Fan and swing mode characteristics into the HeaterCooler accessory. Sample implementation here

ThisIsQasim commented 1 year ago

image

image

kongkx commented 1 year ago

I will check it later, thanks for your info.

Qasim Mehmood @.***>于2023年3月8日 周三18:37写道:

[image: image] https://user-images.githubusercontent.com/18313886/223690814-7797fa53-f795-42b1-a314-0dce62d609e4.png

[image: image] https://user-images.githubusercontent.com/18313886/223690503-6ee321e1-9ec0-4631-9518-e7b15bba5a76.png

— Reply to this email directly, view it on GitHub https://github.com/kongkx/homebridge-gree-air-conditioner/issues/17#issuecomment-1459961252, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXIOOCFD4SUUSDRZ2QRB23W3BOORANCNFSM6AAAAAAVTTAMU4 . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

ThisIsQasim commented 1 year ago

Thank you for implementing this