search

konifar / android-material-design-icon-generator-plugin

This plugin help you to set material design icon to your project.
Apache License 2.0
2.41k stars 239 forks source link

Change icon location to mipmap #27

Open easycheese opened 9 years ago

easycheese commented 9 years ago

As in the title, change the icon location to mipmap vs drawable. Or provide the option?

ahornerr commented 8 years ago

I believe only the Launcher icon (ic_launcher) should be in the mipmap folders. I have a hard time finding a case where someone would want to use a single material icon as their launcher icon. Google guidelines say:

It’s best practice to place your app icons in mipmap- folders (not the drawable- folders) because they are used at resolutions different from the device’s current density. For example, an xxxhdpi app icon can be used on the launcher for an xxhdpi device.

For all other icons, they should be placed in their respective drawable folders so that the device picks the right icon for it's display density.

easycheese commented 8 years ago

You are right, I misunderstood the reason for the mipmap folder. On Jul 13, 2015 09:44, "Andy Horner" notifications@github.com wrote:

I believe only the Launcher icon (ic_launcher) should be in the mipmap folders. I have a hard time finding a case where someone would want to use a single material icon as their launcher icon. Google guidelines say:

It’s best practice to place your app icons in mipmap- folders (not the drawable- folders) because they are used at resolutions different from the device’s current density. For example, an xxxhdpi app icon can be used on the launcher for an xxhdpi device.

For all other icons, they should be placed in their respective drawable folders so that the device picks the right icon for it's display density.

— Reply to this email directly or view it on GitHub https://github.com/konifar/android-material-design-icon-generator-plugin/issues/27#issuecomment-120932383 .

vanniktech commented 8 years ago

I guess this one can be closed then?