konifar / gradle-unused-resources-remover-plugin

Gradle Plugin that removes unused resources in Android projects.
https://plugins.gradle.org/plugin/com.github.konifar.gradle.unused-resources-remover
Apache License 2.0
372 stars 30 forks source link

Format around the first tag in XML isn't preserved. #29

Open thagikura opened 6 years ago

thagikura commented 6 years ago

Overview

The format around the first tag in XML isn't preserved.

Description

When I ran this plugin against a project, one of the modified XML file now looks like as follows The version of the plugin was 0.3.3

<?xml version="1.0" encoding="utf-8"?>
<!--
  ~ Copyright 2018 Google LLC
  ~
  ~ Licensed under the Apache License, Version 2.0 (the "License");
  ~ you may not use this file except in compliance with the License.
  ~ You may obtain a copy of the License at
  ~
  ~     https://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing, software
  ~ distributed under the License is distributed on an "AS IS" BASIS,
  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  ~ See the License for the specific language governing permissions and
  ~ limitations under the License.
  --><resources xmlns:tools="http://schemas.android.com/tools">

      <!-- Redacted -->

</resources>

If you look at the starting "resources" tag, the format was changed unwantedly. The git diff looks like as follows

-  -->
-
-<resources xmlns:tools="http://schemas.android.com/tools">
+  --><resources xmlns:tools="http://schemas.android.com/tools">

It's great if you preserve the original format.

Thanks for the useful plugin by the way!

konifar commented 6 years ago

Thanks for your report! I'll try to fix this on next release