search

konik-io / konik

A library to create, read and validate ZUGFeRD compliant invoices. Available for Java and .NET
https://konik.io
Other
48 stars 19 forks source link

paymentDiscountTerm.setBasis is inaccessible due to its protection level #57

Closed horstoeko closed 5 years ago

horstoeko commented 6 years ago

I am testing konik.io Library using .NET.
I want to setup payment discount for an invoice. I thought I could do this with the class PaymentDiscountTerms:

var paymentDiscountTerm = new PaymentDiscountTerms();
paymentDiscountTerm.setBasis(DiscountAmount, CurrencyCode.EUR));

But this seems not possible - the compiler outputs an error message: paymentDiscountTerm.setBasis is inaccessible due to its protection level

What is going wrong? How is discount managed otherwise?

I made also an issue on stackoverflow: https://stackoverflow.com/questions/51725147/konik-zugferd-paymentdiscountterms

I found a similar issue at https://groups.google.com/forum/#!topic/konik-io/88z6KyQkX5U

Vad1mo commented 6 years ago

could you try it with this dll?

ZUGFeRD.NET-1.3.2-NuGet.zip

horstoeko commented 6 years ago

Please excuse my late feedback, but I was on vacation for a long time. I can say that this version solved my problem. Can you deploy this version on NuGet? We work internally with "Paket" to resolve the corresponding references and this is an availability on NuGet necessary.

Thank you very much for your efforts

Vad1mo commented 6 years ago

yes its on my agenda to update the NuGet, but its not yet automated.

GregorGlinka commented 5 years ago

Hello,

I tried to use the 1.3.2-Version. I added the dll to my Project, replacing the "old" ZUGFeRD.NET. After that I updated via nuget the package for IKVM.NET to the latest Version. Now I can build the EXE without error.

But know I get the exception when I write the PDF with ZUGFerd: The provided PDF is not of type PDF/A. Contact support for an additional PDF to PDF/A conversation

With the old Version I didn't have the Problem with the same PDF. Have you an idea?

Gregor Glinka

Vad1mo commented 5 years ago

@GregorGlinka both versions of the lib don't do any pdf to pdf/a3 conversation. The old version didn't check if the provided PDF is PDF/A compliant. While it appeared that everything worked fine in reality the files weren't ZUGFeRD complaint, which is a bug IMHO.

In the new version the bug is fixed and does check if the PDF provided is a plain PDF.