search

koninklijke-collective / my_redirects

TYPO3 Extension: Redirects management
https://typo3.org/extensions/repository/view/my_redirects
GNU General Public License v2.0
17 stars 20 forks source link

Performance improvment #33

Closed lochmueller closed 7 years ago

lochmueller commented 7 years ago

Hey folks,

I have a very fast page and check the code execution. The redirect check need a lot of power in the frontend, only because the objects are build with the ObjectManager. I checked the code, the ObjectManager features are not used at all (DI & initializeObject call). The performance is much faster if the internal objects are build with GeneralUtility::makeInstance only.

image

Regards, Tim

bmoex commented 7 years ago

Hi @lochmueller,

I removed the ObjectManager initiation from the RequestController and used sub classes, can you try 3.3.0 and give me feedback if you found new info?

Kind regards,

Benjamin Serfhos

ps. What tool did use to find this process?

lochmueller commented 7 years ago

Hey @bmoex

great patch. But please keep the creation of the SignalSlot-Dispatcher with ObjectManager (or call "initializeObject" manually). The Dispatcher use a initializeObject method.

I checked the cachegrind files of xdebug to find this topic. The output tool is qcachegrind

Regards, Tim

bmoex commented 7 years ago

Thanks Tim!

bmoex commented 7 years ago

Just referencing #20 for link :-)