konitter / gulp-combine-media-queries

MIT License
92 stars 28 forks source link

Add source map support #5

Open ckihneman opened 10 years ago

ckihneman commented 10 years ago

I love the idea here, but I've put a lot of effort into ensuring my source maps work properly. And unfortunately this plugin does not handle them. It throws the media query styles after any source map info right now (the bottom of the file).

For the record, from my tests, the plugin works as expected. For now, I'm just going to move this to a final production build step.

Some thoughts on where to go with this... https://github.com/ai/autoprefixer currently handles this situation. They get CSS piped to them, they look for current source maps, then modify the source map depending on what changes autoprefixer makes, then re-inline the source map. It looks like the author even made a library to help post process css: https://github.com/ai/postcss. Maybe you could leverage his efforts there to make your life easier?

And I found your plugin from this post from yeoman by Addy Osmani. So you may be picking up some more traction.

wayferer commented 10 years ago

This would be excellent.

yocontra commented 9 years ago

:+1:

misteroh commented 9 years ago

:+1:

chrismillah commented 9 years ago

:+1: yes please address this

seanogdev commented 9 years ago

:+1: Would be a great addition

waynetheisinger commented 9 years ago

:+1:

robhoeben commented 8 years ago

:+1: I would love to see source-maps support for this plugin

aliciaj commented 8 years ago

:+1:

kaisermann commented 8 years ago

Struggling with this now. Would be awesome to support sourcemaps

seothemes commented 7 years ago

Any news on this?

kaisermann commented 7 years ago

My current workaround was to use postcss with css-mqpacker and it works like a charm

superkon commented 7 years ago

Would be awesome to support sourcemaps