Closed ghost closed 8 years ago
Hey medoc, good functionality and more than happy to include but have some questions about the implementation. I'll annotate the PR diff.
I just submitted another pull request, cancelling this one.
About the recoll version: the current master branch already does not work with recoll 1.17, and you already propose an alternative download for older recoll versions.
There would be 2 rational possibilities: either fix the current master branch for 1.17 compat (this is feasible), or just forget it and clean-up the compatibility bits from the code.
I really think that the 2nd option is better. It will be easy anyway to create an 1.17 compatibility branch if the old version needs maintenance.
I refuse all support for recoll 1.17 anyway: my only answer to any issue with it is to first update using the recoll.org debian repo. I understand the point of having a stable distribution, but users should understand that this also implies living with stable bugs for packages where the developer has no time for maintaining too many multiple branches (and I can fix 1.17 bugs if the hourly rate is comfortable enough :) )
Procures a big improvement (~4x) in performance if 'snippet' is excluded.