search

koniwa / hachiue

HTML-based audio annotation tool
https://koniwa.github.io/hachiue/
GNU Affero General Public License v3.0
7 stars 3 forks source link

Vanishing dummy buttons and actual ←/→ buttons facilitate closing this issue #3 #250

Closed cargilcm closed 4 months ago

cargilcm commented 4 months ago

I think the span width for the pause/play buttons could be explicitly set by css width property instead of no break spaces in the HTML. The nbsp characters pad "play" button so its width is not automatically sized less than that of pauses which moves the other buttons otherwise and gets annoying. Note,I was motivated to close this task because I wanted this feature and like the project and it's design and open source nature. (Mr.?) Yuta "shirayu" Hayashibe was kind enough to review my initial pull request and give me pointers. I am willing to inspect the pause button's default width via Chrome console and set the width for both buttons according to the value reported if desired. Please let me know any issues. THANKS AGAIN FOR YOUR EFFORT. I will continue tweaking to support unique project goals under my forks. Best, Chris Cargile

cargilcm commented 4 months ago

I would really appreciate you Mr "shirayu" if you would consider reviewing this pull request code again, as I am passionate about contributing my code so I can give back (benevolently as it were lol). I have taken care to edit out my debug statements such as console.log and I think this code may better appeal to professional coding standards. Thank you for your considerate review

shirayu commented 4 months ago

Hi, thank you for the pull request.

First of all, could you make this pull request a minimal change for the current master? This is because the diff in this pull request contains non-essential changes and it is difficult to review.

After that, please run

# if needed. Recently switched to Biome from Prettier and Eslint (3161b64)
pnpm i

pnpm format
pnpm test

to pass checks of GitHub Actions.

Thank you.