search

koniwa / hachiue

HTML-based audio annotation tool
https://koniwa.github.io/hachiue/
GNU Affero General Public License v3.0
7 stars 3 forks source link

attempted to pnpm format only partially succeeded with app.js maybe #252

Closed cargilcm closed 4 months ago

cargilcm commented 4 months ago

I don't quite understand why my hachiue project homepage on GitHub shows a different diff from your master branch using this pull request versus the previous one. I did a pull first before incorporating these changes. I can't get biome and sometimes not even pnpm to work, tried Mobile, Windows and Windows subsystem for Linux(debian image). Please let me know if you can incorporate the changes here and approve the pr (by getting around the GitHub actions manually?).

Thank you

http://172.98.73.63/pnpm_format_errs.zip

shirayu commented 4 months ago

I'm using nodejs v22.3.0. That may have something to do with it. (Sorry, but I do not have time to check the logs in detail.)

And before pull requests, please check the followings.

  1. Name the proper title and commit log messages
  2. Check the diff manually to submit pull request to make the diff minimum (For example the sync_modules.sh is deleted)

GitHub actions in pull requests on this repository need my approval. (You can test them on your forked repository before pull request without my approval.)

Thank you

shirayu commented 4 months ago

I have decided to put this repository into maintenance mode because I currently cannot use enough time to maintain this repository. I appreciate your contributions and thank you for your understanding.