search

konklone / campyre

RETIRED: A Campfire client for Android.
https://play.google.com/store/apps/details?id=campyre.android
BSD 3-Clause "New" or "Revised" License
68 stars 22 forks source link

Use recent endpoint instead of transcript endpoint for current room #135

Closed loganj closed 13 years ago

loganj commented 13 years ago

hooray, incremental polling.

As currently implemented, will not quite respect Settings.NUMBER_MESSAGES_KEY if it is set to >100. Will need to either distinguish between that setting and the number fetched, or cap the setting at 100. (100 is the largest number if messages you can fetch from the 'recent' endpoint.)

konklone commented 13 years ago

Thanks for doing this! I'm merging it now, though I am on a train with flakey network access (tethering on my Nexus One) so it's a little touch and go. I'll get your other patch for the null topic room message too.

loganj commented 13 years ago

awesome, thanks!

subList() returns a List view that's backed by the original ArrayList, so we wouldn't be freeing any of the original elements.